Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

一時的なCTCPのtypedefを消し，各所のCTCPをCommonTlmCmdPacket, CommonTlmPacket, CommonCmdPacketのどれかに割り当てる #210

Merged
merged 8 commits into from
Jan 25, 2022
Merged

一時的なCTCPのtypedefを消し，各所のCTCPをCommonTlmCmdPacket, CommonTlmPacket, CommonCmdPacketのどれかに割り当てる #210

merged 8 commits into from
Jan 25, 2022

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Jan 24, 2022 •
edited
Loading

概要

一時的な CTCP の typedef を消し，各所の CTCP を CommonTlmCmdPacket, CommonTlmPacket, CommonCmdPacket のどれかに割り当てる

Issue

詳細

  • CTCPをCCPとTCPに分離 #209 の続き
  • CTCP という型を消し去る
  • 既存の CTCP は 適当に CommonTlmCmdPacket, CommonTlmPacket, CommonCmdPacket になおした．今後，これらが別の実体を指すようになった場合，ここで不適切だった修正はビルドエラーが出るはずなので，そのときに直す

検証結果

既存のCIがすべて通ればOK

影響範囲

ここでは限定的．次に続くPRで大きな影響が出てくる見込み

備考

@meltingrabbit meltingrabbit added enhancement New feature or request priority::high priorityg high labels Jan 24, 2022
@meltingrabbit meltingrabbit self-assigned this Jan 24, 2022
@meltingrabbit meltingrabbit mentioned this pull request Jan 24, 2022
Merged
@meltingrabbit meltingrabbit force-pushed the feature/delete_ctcp_typedef branch 2 times, most recently from c8566b0 to d476001 Compare January 24, 2022 14:08
@meltingrabbit meltingrabbit mentioned this pull request Jan 24, 2022
Closed
@meltingrabbit meltingrabbit changed the title WIP: 一時的なCTCPのtypedefを消し，各所のCTCPをCommonTlmCmdPacket, CommonTlmPacket, CommonCmdPacketのどれかに割り当てる 一時的なCTCPのtypedefを消し，各所のCTCPをCommonTlmCmdPacket, CommonTlmPacket, CommonCmdPacketのどれかに割り当てる Jan 24, 2022
@meltingrabbit meltingrabbit mentioned this pull request Jan 24, 2022
Merged
@meltingrabbit meltingrabbit force-pushed the feature/delete_ctcp_typedef branch from 2c0d599 to 9470fc2 Compare January 25, 2022 01:10
@meltingrabbit meltingrabbit mentioned this pull request Jan 25, 2022
Closed
@meltingrabbit meltingrabbit changed the base branch from feature/divide_ctcp_to_ccp_and_ctp to develop January 25, 2022 15:24
@meltingrabbit
Copy link
Collaborator Author

#209 がマージされたので rebase します．

@meltingrabbit meltingrabbit force-pushed the feature/delete_ctcp_typedef branch from 9470fc2 to d06c4d2 Compare January 25, 2022 15:28
@meltingrabbit meltingrabbit merged commit 1de39cb into develop Jan 25, 2022
@meltingrabbit meltingrabbit deleted the feature/delete_ctcp_typedef branch January 25, 2022 15:32
@meltingrabbit meltingrabbit mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngyu yngyu yngyu approved these changes

@chutaro chutaro Awaiting requested review from chutaro

Assignees

@meltingrabbit meltingrabbit

Labels
enhancement New feature or request priority::high priorityg high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @yngyu